Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race in TestClusteredIndexSyntax #25393

Closed
Tracked by #25899
zhouqiang-cl opened this issue Jun 14, 2021 · 1 comment · Fixed by #25405
Closed
Tracked by #25899

data race in TestClusteredIndexSyntax #25393

zhouqiang-cl opened this issue Jun 14, 2021 · 1 comment · Fixed by #25405
Assignees
@lysu
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@zhouqiang-cl
Copy link
Contributor

Bug Report

[2021-06-14T12:46:16.930Z] [2021/06/14 20:46:16.700 +08:00] [INFO] [session.go:2949] ["use snapshot schema"] [conn=0] [schemaVersion=123]
[2021-06-14T12:46:16.930Z] ==================
[2021-06-14T12:46:16.930Z] WARNING: DATA RACE
[2021-06-14T12:46:16.930Z] Write at 0x00c00023c570 by goroutine 429:
[2021-06-14T12:46:16.930Z]   runtime.mapassign_fast64()
[2021-06-14T12:46:16.930Z]       /usr/local/go/src/runtime/map_fast64.go:92 +0x0
[2021-06-14T12:46:16.930Z]   github.com/pingcap/parser/terror.ErrClass.initError()
[2021-06-14T12:46:16.930Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210610080504-cb77169bfed9/terror/terror.go:156 +0xd6
[2021-06-14T12:46:16.930Z]   github.com/pingcap/parser/terror.ErrClass.NewStdErr()
[2021-06-14T12:46:16.930Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210610080504-cb77169bfed9/terror/terror.go:179 +0x4c
[2021-06-14T12:46:16.930Z]   github.com/pingcap/tidb/ddl.buildTableInfo()
[2021-06-14T12:46:16.930Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1395 +0x22be
[2021-06-14T12:46:16.930Z]   github.com/pingcap/tidb/ddl.buildTableInfoWithStmt()
[2021-06-14T12:46:16.930Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1731 +0x452
[2021-06-14T12:46:16.930Z]   github.com/pingcap/tidb/ddl.(*ddl).CreateTable()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/ddl/ddl_api.go:1814 +0x584
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.(*DDLExec).executeCreateTable()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/ddl.go:205 +0xf6
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.(*DDLExec).Next()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/ddl.go:93 +0x796
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.Next()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/executor.go:286 +0x2a8
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/adapter.go:586 +0x3bc
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/adapter.go:467 +0x276
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/executor/adapter.go:416 +0x63a
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/session.runStmt()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/session/session.go:1653 +0x323
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/session/session.go:1548 +0xc37
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).Exec()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:170 +0x2fc
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).ExecToErr()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:356 +0x96
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustGetErrMsg()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:365 +0x84
[2021-06-14T12:46:16.931Z]   github.com/pingcap/tidb/session_test.(*testClusteredSuite).TestClusteredIndexSyntax()
[2021-06-14T12:46:16.931Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/session/clustered_index_test.go:560 +0x5ee
[2021-06-14T12:46:16.931Z]   runtime.call16()
[2021-06-14T12:46:16.931Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-06-14T12:46:16.931Z]   reflect.Value.Call()
[2021-06-14T12:46:16.931Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-06-14T12:46:16.931Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-06-14T12:46:16.931Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-06-14T12:46:16.931Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-06-14T12:46:16.931Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-06-14T12:46:16.931Z] 
[2021-06-14T12:46:16.931Z] Previous read at 0x00c00023c570 by goroutine 112:
[2021-06-14T12:46:16.931Z]   runtime.mapaccess2_fast64()
[2021-06-14T12:46:16.931Z]       /usr/local/go/src/runtime/map_fast64.go:52 +0x0
[2021-06-14T12:46:16.931Z]   github.com/pingcap/parser/terror.getMySQLErrorCode()
[2021-06-14T12:46:16.931Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210610080504-cb77169bfed9/terror/terror.go:224 +0x20e
[2021-06-14T12:46:16.931Z]   github.com/pingcap/parser/terror.ToSQLError()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/parser@v0.0.0-20210610080504-cb77169bfed9/terror/terror.go:202 +0x55
[2021-06-14T12:46:16.932Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).MustGetErrCode()
[2021-06-14T12:46:16.932Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:377 +0x3c4
[2021-06-14T12:46:16.932Z]   github.com/pingcap/tidb/session_test.(*testSessionSuite3).TestIndexMaxLength.func2()
[2021-06-14T12:46:16.932Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/session/session_test.go:1568 +0x110
[2021-06-14T12:46:16.932Z]   github.com/pingcap/tidb/session_test.(*testSessionSuite3).TestIndexMaxLength()
[2021-06-14T12:46:16.932Z]       /home/jenkins/agent/workspace/tidb-unit-test-nightly/go/src/github.com/pingcap/tidb/session/session_test.go:1577 +0x859
[2021-06-14T12:46:16.932Z]   runtime.call16()
[2021-06-14T12:46:16.932Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-06-14T12:46:16.932Z]   reflect.Value.Call()
[2021-06-14T12:46:16.932Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-06-14T12:46:16.932Z] 
[2021-06-14T12:46:16.932Z] Goroutine 429 (running) created at:
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0x105
[2021-06-14T12:46:16.932Z] 
[2021-06-14T12:46:16.932Z] Goroutine 112 (running) created at:
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-06-14T12:46:16.932Z]   github.com/pingcap/check.(*suiteRunner).asyncRun.func1()
[2021-06-14T12:46:16.932Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:650 +0x105
[2021-06-14T12:46:16.932Z] ==================

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

in ci https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb-unit-test-nightly/runs/649/nodes/113/steps/609/log/?start=0

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master a45b3aa
@zhouqiang-cl zhouqiang-cl added type/bug The issue is confirmed as a bug. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 14, 2021
@lysu lysu self-assigned this Jun 15, 2021
@lysu lysu mentioned this issue Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

@ti-srebot ti-srebot mentioned this issue Jun 15, 2021
Merged
@tisonkun tisonkun mentioned this issue Jul 2, 2021
Closed
This was referenced Sep 18, 2021
Closed
Merged
@ti-srebot ti-srebot mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lysu lysu

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl, executor: fix test race in terror
4 participants
@lysu @aytrack @zhouqiang-cl @ti-srebot