Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting global variables for GC configuration may reports confusing error message #26548

Open
MyonKeminta opened this issue Jul 26, 2021 · 0 comments
Labels
sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.

Comments

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Jul 26, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

set @@global.tidb_gc_life_time = '1m0s';

2. What did you expect to see? (Required)

TiDB reports the value is too small (shorter than 10m, the minimum allowed GC life time), or maybe it's also acceptable that TiDB automatically adjust the value to 10m. (I personally prefer the former)

3. What did you see instead (Required)

ERROR 1232 (42000): Incorrect argument type to variable 'tidb_gc_life_time'

The error message is confusing, and a user may be unable to understand what's going wrong.

4. What is your TiDB version? (Required)

master

@MyonKeminta MyonKeminta added type/bug The issue is confirmed as a bug. sig/transaction SIG:Transaction severity/minor labels Jul 26, 2021
@sticnarf sticnarf added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. severity/minor labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants