Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct placement as table_options #26581

Closed
2 of 7 tasks
morgo opened this issue Jul 26, 2021 · 1 comment · Fixed by pingcap/parser#1327 or #27799
Closed
2 of 7 tasks

Support direct placement as table_options #26581

morgo opened this issue Jul 26, 2021 · 1 comment · Fixed by pingcap/parser#1327 or #27799
Assignees

Comments

@morgo
Copy link
Contributor

morgo commented Jul 26, 2021

This is a sub-task of Placement Rules in SQL: #18030

This requires the following subtasks:

table_option: {
..
 | FOLLOWERS [=] n
 | VOTERS [=] n
 | LEARNERS  [=] n
 | PRIMARY_REGION [=] "str"
 | REGIONS  [=] "str"
 | SCHEDULE [=] "str"
 | CONSTRAINTS  [=] "str"
 | FOLLOWER_CONSTRAINTS  [=] "str"
 | VOTER_CONSTRAINTS  [=] "str"
 | LEARNER_CONSTRAINTS  [=] "str"
 | PLACEMENT POLICY  [=] "str"
}
  • After the support of new syntax for parser, the old syntax should be removed.
  • Ensure that table_options are persisted in TiDB DDL
  • Ensure the database_options for placement are persisted in TiDB DDL
  • Ensure the partitionDef options (usually stored as tableOption in ast) for placement are persisted in TiDB DDL
  • And visible in SHOW CREATE TABLE but always enclosed in a version specific comment (/*T![placement]). executor: Add support for placement in SHOW CREATE TABLE #27792
  • Ensure that table_options respect "Policy Validation" and "Skipping Policy Validation" sections of proposal.
@morgo
Copy link
Contributor Author

morgo commented Sep 7, 2021

I have moved the tasks of this sub-issue to #18030

This was a suggestion to make it easier to see what tasks are unassigned. It makes sense to me, so I am going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants