Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: 5.2 unit test race in (*IndexNestedLoopHashJoin).finishJoinWorkers() #27208

Closed
LittleFall opened this issue Aug 13, 2021 · 1 comment · Fixed by #30619
Closed

CI: 5.2 unit test race in (*IndexNestedLoopHashJoin).finishJoinWorkers() #27208

LittleFall opened this issue Aug 13, 2021 · 1 comment · Fixed by #30619
Labels
component/test severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@LittleFall
Copy link
Contributor

origin pr: #27203
scene: https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/9217/pipeline/
log: https://ci.pingcap.net/blue/rest/organizations/jenkins/pipelines/tidb_ghpr_unit_test/runs/9217/nodes/91/steps/128/log/?start=0

[2021-08-13T09:45:36.552Z] ==================
[2021-08-13T09:45:36.552Z] WARNING: DATA RACE
[2021-08-13T09:45:36.552Z] Read at 0x00c03ceb1888 by goroutine 769:
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).finishJoinWorkers()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:205 +0x3fa
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).finishJoinWorkers-fm()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:201 +0x5e
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/util.WithRecovery.func1()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/misc.go:91 +0x392
[2021-08-13T09:45:36.552Z]   runtime.call16()
[2021-08-13T09:45:36.552Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/store/copr.(*rateLimitAction).Action()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/store/copr/coprocessor.go:1112 +0x16a
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/util/memory.(*Tracker).Consume.func1()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/memory/tracker.go:335 +0xd8
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/util/memory.(*Tracker).Consume()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/memory/tracker.go:343 +0x21a
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/util/chunk.(*List).Add()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/chunk/list.go:115 +0x138
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*outerWorker).buildTask()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_join.go:410 +0x656
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*indexHashJoinOuterWorker).buildTask()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:359 +0x71
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*indexHashJoinOuterWorker).run()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:328 +0x145
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).startWorkers.func1()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:171 +0x53
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/util.WithRecovery()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/misc.go:99 +0x68
[2021-08-13T09:45:36.552Z] 
[2021-08-13T09:45:36.552Z] Previous write at 0x00c03ceb1888 by goroutine 619:
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).startWorkers()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:174 +0xaf7
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).Open()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:154 +0x47a
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:388 +0x4e2
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/session.runStmt()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1786 +0x323
[2021-08-13T09:45:36.552Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()
[2021-08-13T09:45:36.552Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1680 +0xcd7
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).Exec()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:170 +0x2fc
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).QueryToErr()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:357 +0x219
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor_test.(*testSuiteJoinSerial).TestIssue18070()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/join_test.go:2258 +0x2bb
[2021-08-13T09:45:36.553Z]   runtime.call16()
[2021-08-13T09:45:36.553Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-08-13T09:45:36.553Z]   reflect.Value.Call()
[2021-08-13T09:45:36.553Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-08-13T09:45:36.553Z] 
[2021-08-13T09:45:36.553Z] Goroutine 769 (running) created at:
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).startWorkers()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:171 +0x376
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor.(*IndexNestedLoopHashJoin).Open()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/index_lookup_hash_join.go:154 +0x47a
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor.(*ExecStmt).Exec()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/adapter.go:388 +0x4e2
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/session.runStmt()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1786 +0x323
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1680 +0xcd7
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).Exec()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:170 +0x2fc
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/util/testkit.(*TestKit).QueryToErr()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:357 +0x219
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor_test.(*testSuiteJoinSerial).TestIssue18070()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/join_test.go:2258 +0x2bb
[2021-08-13T09:45:36.553Z]   runtime.call16()
[2021-08-13T09:45:36.553Z]       /usr/local/go/src/runtime/asm_amd64.s:550 +0x3d
[2021-08-13T09:45:36.553Z]   reflect.Value.Call()
[2021-08-13T09:45:36.553Z]       /usr/local/go/src/reflect/value.go:337 +0xd8
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0xb3b
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x11d
[2021-08-13T09:45:36.553Z] 
[2021-08-13T09:45:36.553Z] Goroutine 619 (running) created at:
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkCall()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:734 +0x4cc
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).forkTest()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:832 +0x1c4
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).doRun()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:666 +0x144
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.(*suiteRunner).run()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:696 +0x144
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.Run()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:150 +0x5a
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.RunAll()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:136 +0x968
[2021-08-13T09:45:36.553Z]   github.com/pingcap/check.TestingT()
[2021-08-13T09:45:36.553Z]       /nfs/cache/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/run.go:99 +0x756
[2021-08-13T09:45:36.553Z]   github.com/pingcap/tidb/executor_test.TestT()
[2021-08-13T09:45:36.553Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/executor/executor_test.go:107 +0x335
[2021-08-13T09:45:36.553Z]   testing.tRunner()
[2021-08-13T09:45:36.553Z]       /usr/local/go/src/testing/testing.go:1193 +0x202
[2021-08-13T09:45:36.553Z] ==================
@LittleFall LittleFall added the type/bug The issue is confirmed as a bug. label Aug 13, 2021
@jebter jebter added the sig/execution SIG execution label Dec 7, 2021
This was referenced Dec 10, 2021
Closed
Merged
@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: fix data race in the index_lookup_hash_join hawkingrei/tidb
3 participants
@jebter @jingshanglu @LittleFall