Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privilege checks for SHOW PLACEMENT FOR / LIKE #27977

Closed
morgo opened this issue Sep 13, 2021 · 1 comment · Fixed by #28830
Closed

Add privilege checks for SHOW PLACEMENT FOR / LIKE #27977

morgo opened this issue Sep 13, 2021 · 1 comment · Fixed by #28830
Assignees
@lcwangchao
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@morgo
Copy link
Contributor

morgo commented Sep 13, 2021

Enhancement

Part of #18030

We need to add privilege checks for these commands.

Because this info is also available in SHOW CREATE TABLE, we should not consider it to require the PLACEMENT_ADMIN privilege but similar privileges to SHOW CREATE TABLE.

For the LIKE semantic, it should have simliar semantics to SHOW TABLES where it hides objects you do not have permissions for. For FOR it is an exact match, so a no permissions should result in an error.
@morgo morgo added the type/enhancement The issue or PR belongs to an enhancement. label Sep 13, 2021
@morgo morgo mentioned this issue Sep 13, 2021
Closed
@lcwangchao lcwangchao mentioned this issue Sep 24, 2021
Merged
1 task
@lcwangchao
Copy link
Collaborator

lcwangchao commented Sep 26, 2021 •
edited
Loading

@lcwangchao lcwangchao mentioned this issue Oct 14, 2021
Merged
1 task
@lcwangchao lcwangchao linked a pull request Oct 14, 2021 that will close this issue
*: Add SHOW PLACEMENT support for partitions #28830
Merged
1 task
@lcwangchao lcwangchao self-assigned this Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcwangchao lcwangchao

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Add SHOW PLACEMENT support for partitions lcwangchao/tidb
2 participants
@morgo @lcwangchao