Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate UT coverage with CI pipeline #28947

Closed
purelind opened this issue Oct 19, 2021 · 4 comments
Closed

Integrate UT coverage with CI pipeline #28947

purelind opened this issue Oct 19, 2021 · 4 comments

Comments

@purelind
Copy link
Contributor

purelind commented Oct 19, 2021

Related to PingCAP-QE/devops-config#32

To tracking UT coverage at daily basis, even commit basis, UT coverage should be integrated into CI pipeline.
An UT fail case report and an UT coverage report in junit xml format will be much helpful.

There are two problems in current ci for unit-test:

  • Current ci for unit-test print test result to jenkins console, it is not convenient to view failed cases.
  • Need a better way to display Unit-test coverage and ensure unit-test coverage is not below the baseline.

For the two reasons above, i suggest uniform unit-test and coverage output format(Junit XML).

How to do?

  1. use go-junit-report to convert unit-test output to junit xml file
  2. use gocov and gocov-xml to convert coverage report to junit xml file

What changes did we see after the modification?

  1. A better ci display page for failed unit-test cases
    Xnip2021-10-25_14-19-47
  2. A better ci display page for unit-test coverage detail
    Xnip2021-10-25_14-30-14
    Xnip2021-10-25_14-30-35
@kennytm
Copy link
Contributor

kennytm commented Oct 20, 2021

the Google doc is not open to public.

@tisonkun
Copy link
Contributor

I suggest you just inline the content of that doc in the issue. I don't think it requires a design but we'd better review the items you proposed. Also we can later split subtasks from this issue wrt the items.

@purelind
Copy link
Contributor Author

the Google doc is not open to public.

Sorry for this, i will add more details in the issue later.

@purelind
Copy link
Contributor Author

closed by #29848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants