Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support followers=0 syntax #31001

Open
Tracked by #18030
lcwangchao opened this issue Dec 24, 2021 · 2 comments
Open
Tracked by #18030

support followers=0 syntax #31001

lcwangchao opened this issue Dec 24, 2021 · 2 comments

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Dec 24, 2021

Users may want to schedule only one leader without any followers. But when we set followers=0, it will be regarded as user did not set it (int has a default value 0).

@xhebox
Copy link
Contributor

xhebox commented Dec 24, 2021

/cc @morgo , I've forbidden setting it to 0, which makes sense to me. I want to hear from you.

@morgo
Copy link
Contributor

morgo commented Dec 24, 2021

OK, originally I was the same opinion as @xhebox , but on reconsideration @lcwangchao is correct: consider the case that data can be regenerated. In this case you may not wish to have redundancy.

So we should permit the case of followers=0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants