Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forbid to create/alter a table with TTL options when pk contains float/double column #40486

Closed
Tracked by #39262
lcwangchao opened this issue Jan 11, 2023 · 0 comments · Fixed by #40487
Closed
Tracked by #39262

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Jan 11, 2023

For current implementation we construct the delete sql to delete expired rows, for example:

DELETE FROM t WHERE pk IN (1, 2)

If the primary key is a float/double value, the expired rows may not be deleted successfully because the precision problem. We need to forbid creating/altering a table with TTL options in this case.

@lcwangchao lcwangchao mentioned this issue Jan 11, 2023
60 tasks
@lcwangchao lcwangchao added sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement. type/new-feature and removed type/enhancement The issue or PR belongs to an enhancement. labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants