Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use test.Testing() to replace the intest build tag #43630

Open
tiancaiamao opened this issue May 9, 2023 · 0 comments · May be fixed by #46194
Open

use test.Testing() to replace the intest build tag #43630

tiancaiamao opened this issue May 9, 2023 · 0 comments · May be fixed by #46194
Assignees
@tiancaiamao
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

Enhancement

Go 1.21 provide a test.Testing() function, we can use it to replace the go build -tags intest

Ref golang/go#52600
@tiancaiamao tiancaiamao added the type/enhancement The issue or PR belongs to an enhancement. label May 9, 2023
@tiancaiamao tiancaiamao self-assigned this Aug 9, 2023
@tiancaiamao tiancaiamao linked a pull request Aug 17, 2023 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: replace the util/intest package with Go1.21 testing.Testing() tiancaiamao/tidb
1 participant
@tiancaiamao