Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to block the pull requests which will decrease the total test coverage. #45560

Open
wuhuizuo opened this issue Jul 25, 2023 · 1 comment
Open
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Jul 25, 2023

Enhancement

As title said, currently we need to increase the project test coverage, but how to block it in CI that we need to do.

How to do

  1. We can make it failed in github commit status with codecov service feature.
  1. Then we block it with prow tide context policy:
  • set required-if-present-contexts key and add codecov/project into it's value.

Ref

prow's tide configuration example:

tide:
  # .....

  context_options:
    orgs:
      pingcap:
        repos:
          tidb:
            skip-unknown-contexts: true
            from-branch-protection: true
            branches:
              master:
                required-if-present-contexts:
                - "codecov/project"

The configuration is in configs repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant