Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test TestAddIndexIngestRecoverPartition #47105

Closed
Tracked by #41316
hawkingrei opened this issue Sep 20, 2023 · 1 comment · Fixed by #50251
Closed
Tracked by #41316

flaky test TestAddIndexIngestRecoverPartition #47105

hawkingrei opened this issue Sep 20, 2023 · 1 comment · Fixed by #50251
Labels
component/ddl This issue is related to DDL of TiDB. component/test type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Sep 20, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

     testkit.go:136: 
        	Error Trace:	testkit/testkit.go:136
        	            				testkit/testkit.go:129
        	            				ddl/ingest/tests/partition_table_test.go:35
        	Error:      	Received unexpected error:
        	            	[schema:1050]Table 't' already exists
        	            	github.com/pingcap/errors.AddStack
        	            		external/com_github_pingcap_errors/errors.go:174
        	            	github.com/pingcap/errors.Trace
        	            		external/com_github_pingcap_errors/juju_adaptor.go:15
        	            	github.com/pingcap/tidb/ddl.(*ddl).DoDDLJob
        	            		ddl/ddl.go:1196
        	            	github.com/pingcap/tidb/ddl.(*ddl).CreateTableWithInfo
        	            		ddl/ddl_api.go:2728
        	            	github.com/pingcap/tidb/ddl.(*ddl).CreateTable
        	            		ddl/ddl_api.go:2568
        	            	github.com/pingcap/tidb/executor.(*DDLExec).executeCreateTable
        	            		executor/ddl.go:265
        	            	github.com/pingcap/tidb/executor.(*DDLExec).Next
        	            		executor/ddl.go:157
        	            	github.com/pingcap/tidb/executor/internal/exec.Next
        	            		executor/internal/exec/executor.go:283
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).next
        	            		executor/adapter.go:1223
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor
        	            		executor/adapter.go:968
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay
        	            		executor/adapter.go:794
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).Exec
        	            		executor/adapter.go:575
        	            	github.com/pingcap/tidb/session.runStmt
        	            		session/session.go:2421
        	            	github.com/pingcap/tidb/session.(*session).ExecuteStmt
        	            		session/session.go:2271
        	            	github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext
        	            		testkit/testkit.go:353
        	            	github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext
        	            		testkit/testkit.go:134
        	            	github.com/pingcap/tidb/testkit.(*TestKit).MustExec
        	            		testkit/testkit.go:129
        	            	ddl/ingest/tests/tests_test.TestAddIndexIngestRecoverPartition
        	            		ddl/ingest/tests/partition_table_test.go:35
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650
        	Test:       	TestAddIndexIngestRecoverPartition
        	Messages:   	sql:create table t (a int primary key, b int) partition by hash(a) partitions 8;, [], error stack [schema:1050]Table 't' already exists
        	            	github.com/pingcap/errors.AddStack
        	            		external/com_github_pingcap_errors/errors.go:174
        	            	github.com/pingcap/errors.Trace
        	            		external/com_github_pingcap_errors/juju_adaptor.go:15
        	            	github.com/pingcap/tidb/ddl.(*ddl).DoDDLJob
        	            		ddl/ddl.go:1196
        	            	github.com/pingcap/tidb/ddl.(*ddl).CreateTableWithInfo
        	            		ddl/ddl_api.go:2728
        	            	github.com/pingcap/tidb/ddl.(*ddl).CreateTable
        	            		ddl/ddl_api.go:2568
        	            	github.com/pingcap/tidb/executor.(*DDLExec).executeCreateTable
        	            		executor/ddl.go:265
        	            	github.com/pingcap/tidb/executor.(*DDLExec).Next
        	            		executor/ddl.go:157
        	            	github.com/pingcap/tidb/executor/internal/exec.Next
        	            		executor/internal/exec/executor.go:283
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).next
        	            		executor/adapter.go:1223
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor
        	            		executor/adapter.go:968
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelay
        	            		executor/adapter.go:794
        	            	github.com/pingcap/tidb/executor.(*ExecStmt).Exec
        	            		executor/adapter.go:575
        	            	github.com/pingcap/tidb/session.runStmt
        	            		session/session.go:2421
        	            	github.com/pingcap/tidb/session.(*session).ExecuteStmt
        	            		session/session.go:2271
        	            	github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext
        	            		testkit/testkit.go:353
        	            	github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext
        	            		testkit/testkit.go:134
        	            	github.com/pingcap/tidb/testkit.(*TestKit).MustExec
        	            		testkit/testkit.go:129
        	            	ddl/ingest/tests/tests_test.TestAddIndexIngestRecoverPartition
        	            		ddl/ingest/tests/partition_table_test.go:35
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650

https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/47103/tiprow_fast_test/1704289474566950912

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Sep 20, 2023
@hawkingrei hawkingrei mentioned this issue Sep 20, 2023
Open
@jebter
Copy link

jebter commented Sep 21, 2023

/component test
/component ddl

@ti-chi-bot ti-chi-bot bot added component/test component/ddl This issue is related to DDL of TiDB. labels Sep 21, 2023
@tangenta tangenta mentioned this issue Jan 10, 2024
Merged
13 tasks
@tangenta tangenta added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Jan 10, 2024
@ti-chi-bot ti-chi-bot bot closed this as completed in b4ce5d0 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ddl This issue is related to DDL of TiDB. component/test type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: check owner status before commit DDL changes tangenta/tidb
3 participants
@hawkingrei @jebter @tangenta