Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-path should support column projection pushdown #52592

Closed
dbsid opened this issue Apr 12, 2024 · 1 comment · Fixed by #56097
Closed

fast-path should support column projection pushdown #52592

dbsid opened this issue Apr 12, 2024 · 1 comment · Fixed by #56097
Labels
type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@dbsid
Copy link
Contributor

dbsid commented Apr 12, 2024

Feature Request

Is your feature request related to a problem? Please describe:

The fast-path point get in TiDB fetch the whole row from TiKV. There is no column projection pushdown for fast-path Get request as Cop result. This can cause performance degradation in below scenarios are:

  1. Wide tables with many columns, where applications only query a few columns.
  2. JSON fields with large column values, where queries may not necessarily retrieve the values of JSON columns or only extract specific small JSON content.

Describe the feature you'd like:

fast-path point get should support column projection pushdown to TiKV, to reduce the GRPC response message size from TiKV and improve the performance, as well as the resource utilization.
Tn addition, the optimizer need to be aware it's worth to do column projection base on the statistics.

Describe alternatives you've considered:

none

Teachability, Documentation, Adoption, Migration Strategy:

performance enhancement.

@dbsid dbsid added the type/feature-request Categorizes issue or PR as related to a new feature. label Apr 12, 2024
@winoros
Copy link
Member

winoros commented Apr 17, 2024

It's too complicated for that.
I'm also considering removing the fast path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants