Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose optional eval properties on EvaluatorSuit. #54797

Closed
YangKeao opened this issue Jul 22, 2024 · 0 comments · Fixed by #54798
Closed

expose optional eval properties on EvaluatorSuit. #54797

YangKeao opened this issue Jul 22, 2024 · 0 comments · Fixed by #54798
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@YangKeao
Copy link
Member

Enhancement

We have implemented RequiredOptionalEvalProps() function on many builtinFuncs. However, it's not exposed on EvaluatorSuit yet. The EvaluatorSuit is the struct used to evaluate the expression on column (or others). By exposing the optional property on it, the executor can decide whether it's suitable to be detached even if the detached context didn't have a full optional property.
@YangKeao YangKeao added the type/enhancement The issue or PR belongs to an enhancement. label Jul 22, 2024
@YangKeao YangKeao mentioned this issue Jul 22, 2024
Merged
5 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 04e5ff9 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: expose the optional property on EvaluatorSuit YangKeao/tidb
1 participant
@YangKeao