Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable test ddl.TestRecoverTable using infoschema v2 #54846

Closed
tiancaiamao opened this issue Jul 23, 2024 · 1 comment
Closed

Unstable test ddl.TestRecoverTable using infoschema v2 #54846

tiancaiamao opened this issue Jul 23, 2024 · 1 comment
Labels
type/bug The issue is confirmed as a bug.

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

cd pkg/dll
go test -c -tags intest
./ddl.test -test.run  TestRecoverTable  -test.count 100 -test.failfast

2. What did you expect to see? (Required)

No error

3. What did you see instead (Required)

--- FAIL: TestRecoverTable (0.52s)
    attributes_sql_test.go:235: 
                Error Trace:    /home/genius/project/src/github.com/pingcap/tidb/pkg/ddl/attributes_sql_test.go:235
                Error:          "[[schema/test/recover_t key-range "key=value" [7480000000000000ff6800000000000000f8, 7480000000000000ff6900000000000000f8], [7480000000000000ff6900000000000000f8, 7480000000000000ff6a00000000000000f8], [7480000000000000ff6a00000000000000f8, 7480000000000000ff6b00000000000000f8]]]" should have 2 item(s), but has 1
                Test:           TestRecoverTable
FAIL

4. What is your TiDB version? (Required)

master

@tiancaiamao tiancaiamao added the type/bug The issue is confirmed as a bug. label Jul 23, 2024
@tiancaiamao
Copy link
Contributor Author

Caused by an unintentioned change in my PR:

git diff
diff --git a/pkg/infoschema/infoschema_v2.go b/pkg/infoschema/infoschema_v2.go
index 80512fb374..f6cedcb4cb 100644
--- a/pkg/infoschema/infoschema_v2.go
+++ b/pkg/infoschema/infoschema_v2.go
@@ -132,8 +132,8 @@ type tableInfoItem struct {
 
 type partitionItem struct {
        partitionID   int64
-       schemaVersion int64
        tableID       int64
+       schemaVersion int64
        tomb          bool
 }

The master branch is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant