Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the pushed down TopN(tikv, tiflash) can keep the order expression to save cpu or network #56318

Closed
winoros opened this issue Sep 25, 2024 · 1 comment · Fixed by #58208
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@winoros
Copy link
Member

winoros commented Sep 25, 2024

Enhancement

image
The above is one example.

Currently, we keep the output columns unchanged when there's topn pushed down to tikv/tiflash.
But sometimes the order by expression may reduce the size of the column data transferred by the network significantly.
And another example is that the expression's evaluation cost is rather high. In that time we can also keep the expression, not to calculate it twice on tidb and tiflash/tikv.

@winoros winoros added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Sep 25, 2024
@EricZequan
Copy link
Contributor

Implement: #58208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants