Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cop task's backoff time is not appropriate in execution summary #58703

Closed
Tracked by #56232
yibin87 opened this issue Jan 6, 2025 · 6 comments · Fixed by #58707
Closed
Tracked by #56232

Cop task's backoff time is not appropriate in execution summary #58703

yibin87 opened this issue Jan 6, 2025 · 6 comments · Fixed by #58707
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Jan 6, 2025 •
edited
Loading

In current tidb code, the cop task's backoff time in execution summary is not correctly calculated:

tidb/pkg/distsql/select_result.go

Line 658 in 4f78f12

maps.Copy(s.backoffSleep, copStats.BackoffSleep)

The backoff time in selectResultRuntimeStats is replaced by the new CopRuntimeStats's backoff time when their backoff keys are the same. It is more reasonable to sum the backoff values up here.
Currently, the accurate backoff info can be found in the slow log item if the query is regarded as a slow query.
@yibin87 yibin87 added the type/bug The issue is confirmed as a bug. label Jan 6, 2025
This was referenced Jan 6, 2025
Open
Merged
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025

/label affects-8.5

@ti-chi-bot ti-chi-bot bot added the affects-8.5 This bug affects the 8.5.x(LTS) versions. label Jan 6, 2025
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025

/severity major

@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025

/label affects-8.1
/label affects-7.5
/label affects-7.1
/label affects-6.5

@ti-chi-bot ti-chi-bot bot added affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. and removed may-affects-8.1 may-affects-7.5 may-affects-7.1 may-affects-6.5 labels Jan 6, 2025
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025

/label affects-6.1
/label affects-5.4

@ti-chi-bot ti-chi-bot bot added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-5.4 This bug affects the 5.4.x(LTS) versions. and removed may-affects-6.1 may-affects-5.4 This bug maybe affects 5.4.x versions. labels Jan 6, 2025
@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025

/severity minor

@yibin87
Copy link
Contributor Author

yibin87 commented Jan 6, 2025 •
edited
Loading

/remove-severity major

@ti-chi-bot ti-chi-bot bot closed this as completed in 1756a8d Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

distsql: Fix backoff execution info inaccurate issue yibin87/tidb
1 participant
@yibin87