Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeferredExpr is lost in constant folding #7914

Closed
eurekaka opened this issue Oct 16, 2018 · 0 comments
Closed

DeferredExpr is lost in constant folding #7914

eurekaka opened this issue Oct 16, 2018 · 0 comments
Assignees
Labels
component/expression type/bug The issue is confirmed as a bug.

Comments

@eurekaka
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

When reviewing #7808, I realized that we lost DeferredExpr of Constant when doing aggressive constant folding(introduced in #7696).

  1. What did you expect to see?

We should maintain this property of Constant.

  1. What did you see instead?

DeferredExpr is lost in constant folding.

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
mysql> select tidb_version();
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                                                                                    |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v2.1.0-rc.3-44-g660191c
Git Commit Hash: 660191c5d7a28bea4a871e3e6d338cd9d0aef5a4
Git Branch: master
UTC Build Time: 2018-10-12 11:17:26
GoVersion: go version go1.11rc1 linux/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false |
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant