Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support modify column on partitioned table #38302

Merged
merged 8 commits into from
Oct 13, 2022
Merged

ddl: support modify column on partitioned table #38302

merged 8 commits into from
Oct 13, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 5, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38297

Problem Summary:

Support for partitioned tables was never added for MODIFY COLUMN.

What is changed and how it works?

Removed the limitation and added handling of partitions for the column change DDL operation. Updating indexes was already supported for partitioned tables, so only the table data / rows handling needed to be updated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support `ALTER TABLE t MODIFY column...` on partitioned table

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Oct 5, 2022

/run-check_dev

@mjonss
Copy link
Contributor Author

mjonss commented Oct 5, 2022

/run-unit-test

1 similar comment
@mjonss
Copy link
Contributor Author

mjonss commented Oct 7, 2022

/run-unit-test

@mjonss
Copy link
Contributor Author

mjonss commented Oct 7, 2022

/run-check_dev

Defined2014
Defined2014 approved these changes Oct 10, 2022
View reviewed changes
ddl/failtest/fail_db_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2022
mjonss and others added 2 commits October 10, 2022 14:47
@mjonss
Update fail_db_test.go
4b119dd 
According to review suggestion
@mjonss
Fixed test case
a3a5af9
@mjonss mjonss requested a review from zimulala October 13, 2022 08:33
@mjonss
Copy link
Contributor Author

mjonss commented Oct 13, 2022

/run-check_dev

bb7133
bb7133 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 13, 2022
@bb7133
Copy link
Member

bb7133 commented Oct 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a3a5af9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Oct 13, 2022

/run-mysql-test

@mjonss
Copy link
Contributor Author

mjonss commented Oct 13, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit af714c2 into pingcap:master Oct 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 11 min Existing failure
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 3 min 55 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 22 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 8 min 52 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 4 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 56 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@mjonss mjonss deleted the allow-mod-col-on-part branch October 13, 2022 21:47
mjonss added a commit that referenced this pull request Oct 13, 2022
@mjonss @xiongjiwei @Yisaer
Merge master into feature branch (#38463)
0d316ef 
* mockkv: make pk id = -1 if no primary key column is used (#38443)

* ddl: support modify column on partitioned table (#38302)

close #38297

* planner: revise isnullRejected check for `And` and `OR` (#38430)

close #38304

Co-authored-by: xiongjiwei <xiongjiwei1996@outlook.com>
Co-authored-by: Song Gao <disxiaofei@163.com>
@mjonss mjonss mentioned this pull request Oct 18, 2022
Closed
@mjonss mjonss mentioned this pull request Oct 27, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 4, 2022
Merged
12 tasks
This was referenced Dec 14, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@bb7133 bb7133 bb7133 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MODIFY COLUMN of partitioned tables
5 participants
@mjonss @ti-chi-bot @bb7133 @sre-bot @Defined2014