Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate MPP task #1706

Closed
zanmato1984 opened this issue Mar 30, 2021 · 2 comments · Fixed by pingcap/tidb#23747
Closed

Duplicate MPP task #1706

zanmato1984 opened this issue Mar 30, 2021 · 2 comments · Fixed by pingcap/tidb#23747
Assignees
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@zanmato1984
Copy link
Contributor

zanmato1984 commented Mar 30, 2021

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tiflash_regression_test_daily/detail/tiflash_regression_test_daily/2269/pipeline

[2021-03-30T07:43:56.555Z] ERROR 1105 (HY000) at line 1: DB::Exception: The task [423910502926385155,1] has been registered

After some investigation, we found that:

  • TiFlash MPP task manager maintains a map from MPP task id to a concrete MPP task;
  • A MPP task is identified by its associated transaction start_ts and a intra-query integer (self-incremental within the query);
  • When several queries share the same start_ts, typically in single transaction started by begin statement, MPP tasks of different queries may have the same MPP task id;
  • There is a small chance that the last query finishes and the next query starts executing, but MPP task manager hasn't removed the MPP task with the same id from the previous query;
  • Thus the duplicated MPP task.
@ilovesoup
Copy link
Contributor

Would you please describe the issue more clear in case we want to review in the future..

@zanmato1984
Copy link
Contributor Author

Would you please describe the issue more clear in case we want to review in the future..

Updated in issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants