You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
We use grpc + protobuf to send message between TiFlash nodes, however, protobuf has a hard limit of 2GB, so if the message size exceeds 2GB, we should throw out error. However, after #3184, there is a chance that
the size of MPPDataPacket exceeds 2GB, and this will cause TiFlash server crash. A typical crash stack is
The root cause of generating such a huge MPPDataPacket is #3436, but before #3436 is fixed, we should at least throw out error explicitly instead of make TiFlash crash.
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)
The text was updated successfully, but these errors were encountered:
According to #3436, the size of block generated by Join expression is actually unlimited, and if join generate huge block(for example: using wrong query plan for tpch q5), before #3184, TiFlash will throw error after #3184, it will be crashed.
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
We use grpc + protobuf to send message between TiFlash nodes, however, protobuf has a hard limit of 2GB, so if the message size exceeds 2GB, we should throw out error. However, after #3184, there is a chance that
the size of
MPPDataPacket
exceeds 2GB, and this will cause TiFlash server crash. A typical crash stack isThe root cause of generating such a huge
MPPDataPacket
is #3436, but before #3436 is fixed, we should at least throw out error explicitly instead of make TiFlash crash.2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)
The text was updated successfully, but these errors were encountered: