Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up DeltaMergeStore::DeltaMergeStore #7146

Closed
Tracked by #7145
hongyunyan opened this issue Mar 23, 2023 · 0 comments · Fixed by #6971
Closed
Tracked by #7145

Speed up DeltaMergeStore::DeltaMergeStore #7146

hongyunyan opened this issue Mar 23, 2023 · 0 comments · Fixed by #6971
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@hongyunyan
Copy link
Contributor

Enhancement

When we restart tiflash, we need to init all DeltaMergeStore, in DeltaMergeStore::DeltaMergeStore we need to restore a lot of dmfiles, which make the restart a long time.

Besides, we find now in DeltaMergeStore::DeltaMergeStore we restore each dmfile twice, which not necessary here. Thus we can reduce the restore dmfile times to speed up.
@hongyunyan hongyunyan added the type/enhancement The issue or PR belongs to an enhancement. label Mar 23, 2023
This was referenced Mar 23, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce DMFile::restore in DeltaMergeStore::DeltaMergeStore hongyunyan/tiflash
1 participant
@hongyunyan