-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alloc_bytes
of ReadLimiter
#5852
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
dbms/src/Encryption/RateLimiter.cpp
Outdated
@@ -191,6 +210,7 @@ void WriteLimiter::request(Int64 bytes) | |||
} | |||
} | |||
} | |||
LOG_FMT_DEBUG(log, "pending_us {} wait_times {} pending_count {} rate_limit_per_sec {}", sw_pending.elapsed() / 1000, wait_times, req_queue.size(), refill_balance_per_period * 1000 / refill_period_ms); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too chatty. Use trace please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And perhaps report to grafana if neccesary?
/run-all-tests |
2 similar comments
/run-all-tests |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
dd64e76
to
c0b994e
Compare
alloc_bytes
of ReadLimiteralloc_bytes
of ReadLimiter
c0b994e
to
fc1dbbd
Compare
/merge |
@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: fc1dbbd
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/merge |
@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
@JinheLin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
In response to a cherrypick label: new pull request created: #5930. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #5801
Problem Summary:
alloc_bytes
is not right when the burst read traffic exceeds the limit and results in the I/O limiter-tuner not working well.available_balance
is negative (overdrawn),refillAndAlloc
will refresh it periodically. However, ReadLimiter may not be called for a long time and refillAndAlloc will not be called either.What is changed and how it works?
Before this PR:
Include this PR:
Check List
Tests
Side effects
Documentation
Release note