Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor kafka sink metrics #11532

Closed
3AceShowHand opened this issue Aug 28, 2024 · 0 comments · Fixed by #11533
Closed

refactor kafka sink metrics #11532

3AceShowHand opened this issue Aug 28, 2024 · 0 comments · Fixed by #11533
Assignees
@3AceShowHand
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

  • clean up the metrics when exit the loop immediately
  • fix some delete metrics issue
@3AceShowHand 3AceShowHand self-assigned this Aug 28, 2024
@3AceShowHand 3AceShowHand added component/metrics-logging Metrics and logging component. type/enhancement The issue or PR belongs to an enhancement. area/ticdc Issues or PRs related to TiCDC. labels Aug 28, 2024
@3AceShowHand 3AceShowHand mentioned this issue Aug 28, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in 8306633 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kafka(ticdc): make kafka metrics more robust 3AceShowHand/tiflow
1 participant
@3AceShowHand