Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata error with MariaDB 11.4 #11735

Open
dveeden opened this issue Nov 8, 2024 · 6 comments · May be fixed by #11743
Open

metadata error with MariaDB 11.4 #11735

dveeden opened this issue Nov 8, 2024 · 6 comments · May be fixed by #11743
Assignees
Labels
area/dm Issues or PRs related to DM. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. MariaDB This issue is found with MariaDB upstream severity/moderate type/bug The issue is confirmed as a bug.

Comments

@dveeden
Copy link
Contributor

dveeden commented Nov 8, 2024

What did you do?

Setup DM with MariaDB 11.4

What did you expect to see?

"Message": "parse mydumper metadata error: [code=11123:class=functional:scope=upstream:level=low], Message: didn't found binlog location in dumped metadata file metadata, Workaround: Please check log of dump unit, there maybe errors when read upstream binlog status, metadata: Started dump at: 2024-11-08 16:30:53\nSHOW BINARY LOG STATUS:\n\tLog: mysqld-bin.000002\n\tPos: 329\n\tGTID:\n\nFinished dump at: 2024-11-08 16:30:54\n",

What did you see instead?

No response

Versions of the cluster

master @ 64decf6

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@dveeden dveeden added area/dm Issues or PRs related to DM. type/bug The issue is confirmed as a bug. labels Nov 8, 2024
@dveeden

This comment was marked as outdated.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 8, 2024

/label MariaDB

@ti-chi-bot ti-chi-bot bot added the MariaDB This issue is found with MariaDB upstream label Nov 8, 2024
@lance6716
Copy link
Contributor

lance6716 commented Nov 11, 2024

From error message we know the content is

Started dump at: 2024-11-08 16:30:53
SHOW BINARY LOG STATUS:
	Log: mysqld-bin.000002
	Pos: 329
	GTID:

Finished dump at: 2024-11-08 16:30:54

caused by

switch line {
case "SHOW MASTER STATUS:":
if err3 := parsePosAndGTID(&pos, &gtidStr); err3 != nil {
return nil, nil, err3
}
case "SHOW SLAVE STATUS:":
// ref: https://github.com/maxbube/mydumper/blob/master/mydumper.c#L434
for {
line, err3 := br.ReadString('\n')
if err3 != nil {
return nil, nil, err3
}
line = strings.TrimSpace(line)
if len(line) == 0 {
break
}
}
case "SHOW MASTER STATUS: /* AFTER CONNECTION POOL ESTABLISHED */":
useLocation2 = true
if err3 := parsePosAndGTID(&pos2, &gtidStr2); err3 != nil {
return nil, nil, err3
}

we didn't handle SHOW BINARY LOG STATUS

@lance6716 lance6716 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate labels Nov 11, 2024
@joccau
Copy link
Member

joccau commented Nov 11, 2024

/assign

@joccau joccau linked a pull request Nov 13, 2024 that will close this issue
4 tasks
@joccau
Copy link
Member

joccau commented Nov 14, 2024

What did you do?

Setup DM with MariaDB 11.4

What did you expect to see?

"Message": "parse mydumper metadata error: [code=11123:class=functional:scope=upstream:level=low], Message: didn't found binlog location in dumped metadata file metadata, Workaround: Please check log of dump unit, there maybe errors when read upstream binlog status, metadata: Started dump at: 2024-11-08 16:30:53\nSHOW BINARY LOG STATUS:\n\tLog: mysqld-bin.000002\n\tPos: 329\n\tGTID:\n\nFinished dump at: 2024-11-08 16:30:54\n",

What did you see instead?

No response

Versions of the cluster

master @ 64decf6

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)

Is the answers to question reversed for What did you expect to see? and What did you see instead? ?

@dveeden
Copy link
Contributor Author

dveeden commented Nov 14, 2024

@joccau yes indeed. When setting up DM with MariaDB 11.4 I would expect it to work, but what I see instead is this error that mentions SHOW BINARY LOG STATUS.

I'm not sure it should mention SHOW BINARY LOG STATUS as that's for recent versions of MySQL and with MariaDB I would expect SHOW MASTER STATUS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. MariaDB This issue is found with MariaDB upstream severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants