Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL lost after owner is killed (kill_owner_with_ddl fails) #1260

Closed
liuzix opened this issue Dec 31, 2020 · 1 comment
Closed

DDL lost after owner is killed (kill_owner_with_ddl fails) #1260

liuzix opened this issue Dec 31, 2020 · 1 comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/replica-model Replication model component. priority/P1 The issue has P1 priority. type/bug The issue is confirmed as a bug.
Milestone
v4.0.11

Comments

@liuzix
Copy link
Contributor

liuzix commented Dec 31, 2020

DDL can be lost after adjusting order of owner operations. The owner now tries to flush changefeed status right after recalculating the ts's. Consider the following scenario:

  • Owner recalculates the global checkpointTs to A, which is the finishTs of a DDL.
  • Owner successfully upload the new the global checkpointTs, which gets persisted in Etcd.
  • Owner gets killed before successfully executing DDL.
  • New Owner thinks this DDL has already been executed.

This scenario is a conjecture, please comment if you have more thoughts on this.
@liuzix liuzix added type/bug The issue is confirmed as a bug. component/replica-model Replication model component. labels Dec 31, 2020
@amyangfei amyangfei added priority/P0 The issue has P0 priority. priority/P1 The issue has P1 priority. and removed priority/P0 The issue has P0 priority. labels Dec 31, 2020
@amyangfei amyangfei added this to the v4.0.11 milestone Jan 28, 2021
@amyangfei
Copy link
Contributor

Have been fixed by https://github.com/pingcap/ticdc/pull/1236.

the checkpoint won't be updated to DDL FinishedTs until the DDL has ben executed successfully

@liuzix liuzix mentioned this issue Jul 8, 2021
Merged
This was referenced Jul 14, 2021
Merged
Merged
Merged
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/replica-model Replication model component. priority/P1 The issue has P1 priority. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
v4.0.11
Development

No branches or pull requests
3 participants
@amyangfei @liuzix @AkiraXie