Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail-fast for unrecoverable DML errors #1724

Closed
liuzix opened this issue Apr 29, 2021 · 2 comments
Closed

Fail-fast for unrecoverable DML errors #1724

liuzix opened this issue Apr 29, 2021 · 2 comments
Assignees
@ben1009
Labels
bug-from-user Bugs found by users. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@liuzix
Copy link
Contributor

liuzix commented Apr 29, 2021

Feature Request

Is your feature request related to a problem? Please describe:
Users can be frustrated if an unrecoverable error such as tableNotExists is not reported in a timely fashion.

Describe the feature you'd like:
Instead of retrying, the sink should fail fast when a DML error is likely to be unrecoverable without manual intervention.

Describe alternatives you've considered:
Report currently on-going retries.

Teachability, Documentation, Adoption, Migration Strategy:
We should take care to ensure that failed changefeeds are periodically retried, in case the user completed the manual intervention and expects the changefeed to continue on its own.
@liuzix liuzix added the subject/new-feature Denotes an issue or pull request adding a new feature. label Apr 29, 2021
@amyangfei
Copy link
Contributor

duplicated with pingcap/ticdc#525

@overvenus overvenus added the bug-from-user Bugs found by users. label May 12, 2021
@ben1009 ben1009 self-assigned this May 19, 2021
@ben1009 ben1009 mentioned this issue May 26, 2021
Merged
@ben1009 ben1009 mentioned this issue Jun 8, 2021
Merged
This was referenced Jun 25, 2021
Merged
Merged
Merged
@overvenus overvenus added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed type/cost-effective-bug labels Jul 8, 2021
This was referenced Jul 19, 2021
Merged
Merged
Merged
@ben1009
Copy link
Contributor

ben1009 commented Aug 12, 2021

close this one, all prs got merged

@ben1009 ben1009 closed this as completed Aug 12, 2021
@ben1009 ben1009 mentioned this issue Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben1009 ben1009

Labels
bug-from-user Bugs found by users. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. severity/moderate subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amyangfei @ben1009 @overvenus @liuzix @Tammyxia