Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should TiCDC continue replicating data during rolling update #3261

Closed
amyangfei opened this issue Nov 4, 2021 · 2 comments
Closed

Should TiCDC continue replicating data during rolling update #3261

amyangfei opened this issue Nov 4, 2021 · 2 comments
Labels
area/ticdc Issues or PRs related to TiCDC. status/need-discussion Issue that needs to be discussed to confirm priority, milestone, plan and task breakdown. subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Nov 4, 2021

Is your feature request related to a problem?

For example if we deploy a TiDB cluster across three AZs to achieve high availability, and also deploy one TiCDC server in each AZ to replicate data from TiDB to downstream.

We we want to upgrade the TiDB cluster, we could perform a rolling upgrade for servers one by one, in the order of AZ.

Since the rolling upgrade of TiKV could be very slow (as long as hours), there will exist different versions of TiCDC in the whole cluster for quite a long time. During that time, TiCDC refuses to replicate data because of strict version check, ref:

https://github.com/pingcap/ticdc/blob/6655bf0835c8bbd31d949b7c8da79bf09e6f5a3c/cdc/owner/owner.go#L271-L280

Describe the feature you'd like

Loosen the version check strategy, such as when upgrading TiCDC from v5.2.2 to v5.2.3, TiCDC can continue replicate during rolling upgrade.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response

@amyangfei amyangfei added subject/new-feature Denotes an issue or pull request adding a new feature. status/need-discussion Issue that needs to be discussed to confirm priority, milestone, plan and task breakdown. labels Nov 4, 2021
@ben1009
Copy link
Contributor

ben1009 commented Nov 4, 2021

@Rustin170506 Rustin170506 added the area/ticdc Issues or PRs related to TiCDC. label Nov 5, 2021
@amyangfei
Copy link
Contributor Author

Solved by #4757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. status/need-discussion Issue that needs to be discussed to confirm priority, milestone, plan and task breakdown. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants