Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler failed to keep consistent relay status if master/worker restart in particular order #3478

Closed
lance6716 opened this issue Nov 16, 2021 · 0 comments · Fixed by #3474
Labels
area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

What did you do?

https://github.com/pingcap/ticdc/blob/bc6029e22fbf38612184765ee802431663e4fa10/dm/tests/new_relay/run.sh#L86

prerequisite

  1. start-relay -s source1 worker1
  2. kill worker1 (don't use kill -9)
  3. restart master
  4. start worker1

now DM master lost the relay status of that worker in memory, in other words, it will treat that worker as a free worker. but the worker is indeed pulling relay logs.

the inconsistency will become a problem when master tries to bound another source to the worker. At then worker will report same error like pingcap/dm#2204

What did you expect to see?

above integration test will pass, which means after master and worker restarts, two worker status of source2 is bound + relay

What did you see instead?

two worker status of source2 is bound + free

Versions of the cluster

DM version (run dmctl -V or dm-worker -V or dm-master -V):

master (5.3.0)

current status of DM cluster (execute query-status <task-name> in dmctl)

(paste current status of DM cluster here)
@lance6716 lance6716 added type/bug The issue is confirmed as a bug. area/dm Issues or PRs related to DM. severity/major labels Nov 16, 2021
@lance6716 lance6716 changed the title scheduler failed to keep consistent relay status if master/worker restart in a order scheduler failed to keep consistent relay status if master/worker restart in particular order Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant