Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race found in TestRevisionNotFallBack #4473

Closed
Tracked by #2246
glorv opened this issue Jan 25, 2022 · 1 comment
Closed
Tracked by #2246

data race found in TestRevisionNotFallBack #4473

glorv opened this issue Jan 25, 2022 · 1 comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component.

Comments

@glorv
Copy link
Contributor

glorv commented Jan 25, 2022

Which jobs are flaking?

leak-test

Which test(s) are flaking?

TestRevisionNotFallBack

Jenkins logs or GitHub Actions link

[2022-01-25T05:41:21.422Z] ==================

[2022-01-25T05:41:21.422Z] WARNING: DATA RACE

[2022-01-25T05:41:21.422Z] Read at 0x00c0009003c0 by goroutine 66:

[2022-01-25T05:41:21.422Z]   github.com/pingcap/tiflow/pkg/etcd.TestRevisionNotFallBack()

[2022-01-25T05:41:21.422Z]       /home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/tiflow/pkg/etcd/client_test.go:273 +0x6eb

[2022-01-25T05:41:21.422Z]   testing.tRunner()

[2022-01-25T05:41:21.422Z]       /usr/local/go/src/testing/testing.go:1193 +0x202

[2022-01-25T05:41:21.422Z] 

[2022-01-25T05:41:21.422Z] Previous write at 0x00c0009003c0 by goroutine 68:

[2022-01-25T05:41:21.422Z]   github.com/pingcap/tiflow/pkg/etcd.mockWatcher.Watch()

[2022-01-25T05:41:21.422Z]       /home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/tiflow/pkg/etcd/client_test.go:55 +0x72

[2022-01-25T05:41:21.422Z]   github.com/pingcap/tiflow/pkg/etcd.(*mockWatcher).Watch()

[2022-01-25T05:41:21.422Z]       <autogenerated>:1 +0x124

[2022-01-25T05:41:21.422Z]   github.com/pingcap/tiflow/pkg/etcd.(*Client).WatchWithChan()

[2022-01-25T05:41:21.422Z]       /home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/tiflow/pkg/etcd/client.go:246 +0x1339

[2022-01-25T05:41:21.422Z]   github.com/pingcap/tiflow/pkg/etcd.TestRevisionNotFallBack.func2()

[2022-01-25T05:41:21.422Z]       /home/jenkins/agent/workspace/cdc_ghpr_leak_test/go/src/github.com/pingcap/tiflow/pkg/etcd/client_test.go:266 

Details: https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_leak_test/detail/cdc_ghpr_leak_test/19181/pipeline

Anything else we need to know

  • Does this test exist for other branches as well?

  • Has there been a high frequency of failure lately?

@glorv glorv added component/test Unit tests and integration tests component. area/ticdc Issues or PRs related to TiCDC. labels Jan 25, 2022
@overvenus
Copy link
Member

Duplicate of #4549

@overvenus overvenus marked this as a duplicate of #4549 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component.
Projects
None yet
Development

No branches or pull requests

2 participants