Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo log seems use too many expensive operations for NFS #6051

Open
4 tasks done
Tracked by #5920
hicqu opened this issue Jun 27, 2022 · 0 comments
Open
4 tasks done
Tracked by #5920

redo log seems use too many expensive operations for NFS #6051

hicqu opened this issue Jun 27, 2022 · 0 comments
Labels
question Further information is requested.

Comments

@hicqu
Copy link
Contributor

hicqu commented Jun 27, 2022

Before asking a question, make sure you have

What is your question?

Some users store redo-log on NFS and they found some operations are too expensive for NFS:
图片
图片

We can see the latency of fsync, rename and trunc is too high.

fsync is called in WriteLog and flushLogMeta; rename is called in flush and flushLogMeta. trunc is only called in flushLogMeta.

And, flushLogMeta holds LogWriter.metaLock so it can block setMaxCommitTs and GetCurrentResolvedTs.

We need to

  1. move all I/O operations into background goroutines, so that all redo-log interfaces can be no-blocking;
  2. improve the usage of LogWrite.metaLock.
@hicqu hicqu added the question Further information is requested. label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested.
Projects
None yet
Development

No branches or pull requests

1 participant