ignore tombstone store. #1045
Merged
ignore tombstone store. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed @BusyJay |
huachaohuang
force-pushed
the
huachaohuang/ignore-tombstone-store
branch
from
910a3e4 to
5ca62a6
Compare
| @@ -133,3 +137,90 @@ impl StoreAddrResolver for MockStoreAddrResolver { | |||
| unimplemented!(); | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
There was a problem hiding this comment.
can we mock a PD server in pd mod, so we don't need to start a real PD server in CI test.
There was a problem hiding this comment.
We can mock PdClient for tests, and we already have a TestPdClient in tests/raftstore/pd.rs.
There was a problem hiding this comment.
What I mean is not start PD server in travis CI for testing pd mod.
There was a problem hiding this comment.
we can add fire an issue later if we can mock.
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.