raftstore: cache term #1154
Merged
raftstore: cache term #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Oct 11, 2016
| @@ -160,6 +163,16 @@ impl PeerStorage { | |||
| raft_state | |||
| } | |||
| }; | |||
| let last_term = match raft_state.get_last_index() { | |||
| 0 => 0, | |||
There was a problem hiding this comment.
any test to cover 0 and RAFT_INIT_LOG_INDEX ?
There was a problem hiding this comment.
Existing cases cover it already.
hhkbp2
reviewed
Oct 11, 2016
| @@ -279,6 +293,9 @@ impl PeerStorage { | |||
| return Ok(self.truncated_term()); | |||
| } | |||
| try!(self.check_range(idx, idx + 1)); | |||
| if self.truncated_term() == self.last_term || idx == self.last_index() { | |||
There was a problem hiding this comment.
Why check truncated_term() here?
|
LGTM |
|
PTAL |
|
LGTM |
1 similar comment
|
LGTM |
zhangjinpeng87
pushed a commit
that referenced
this pull request
Oct 17, 2016
mittalrishabh
pushed a commit
to mittalrishabh/tikv
that referenced
this pull request
Nov 22, 2024
* Configurable lowres tso update interval Signed-off-by: Ari Ekmekji <aekmekji@gmail.com> * Review comments Signed-off-by: Ari Ekmekji <aekmekji@gmail.com> * Comment for exported function Signed-off-by: Ari Ekmekji <aekmekji@gmail.com> --------- Signed-off-by: Ari Ekmekji <aekmekji@gmail.com> Co-authored-by: Ari Ekmekji <ari.ekmekji@airbnb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently almost every call to term will invoke
rocksdb::get. This pr reduce the call times by caching the term of last_index. Iftruncated_termis equal tolast_term, then every entry between truncated_index and last_index should have the same term.