txn:improvement for point get by unique key or pk #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts==uint64::max(which means is a point get by pk or unique_key in tidb)
|
PTAL @hhkbp2 |
disksing
reviewed
Feb 14, 2017
src/storage/mvcc/reader.rs
Outdated
| ts: lock.ts, | ||
| ttl: lock.ttl, | ||
| }); | ||
| let raw_key = try!(key.raw()); |
There was a problem hiding this comment.
Move it into if ts == u64::MAX.
src/storage/mvcc/reader.rs
Outdated
| if ts == u64::MAX && raw_key == primary_key { | ||
| // when ts==MAX(which means it's a point get by pk or unique key), | ||
| // and current key is the primary key, | ||
| // return latest commit version's value |
There was a problem hiding this comment.
It looks strange for MVCC to be mixed with the concept of pk or unique key. Maybe better to extract a get_latest(&mut self, key: &Key) method.
There was a problem hiding this comment.
I do not think is a good idea to extract get_latest(&mut self, key: &Key) since we use this through coprocessor, use get_latest may change too much.
|
PTAL |
hhkbp2
reviewed
Feb 17, 2017
src/storage/mvcc/reader.rs
Outdated
| ttl: lock.ttl, | ||
| }); | ||
| if ts == u64::MAX && try!(key.raw()) == lock.primary { | ||
| // when ts==MAX(which means get latest committed version for primary key), |
There was a problem hiding this comment.
s/ts== MAX(which means get / ts == u64::MAX (which means to get/
|
Rest LGTM |
|
LGTM |
|
PTAL @hhkbp2 |
|
any performance increased? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement improvement for point get by unique key or pk with tidb.
For
Getwith ts==uint64::max(which means it's a point get by pk or unique_key from tidb), if lock exist and current key the primary, return latest committed version instead of ErrorWithLock.@disksing @zhangjinpeng1987 PTAL