raftstore: clean callback when peer is destroyed #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed |
hhkbp2
reviewed
Mar 17, 2017
tests/raftstore/test_lease_read.rs
Outdated
| @@ -380,3 +385,37 @@ fn test_server_lease_unsafe_during_leader_transfers() { | |||
| let mut cluster = new_node_cluster(0, count); | |||
| test_lease_unsafe_during_leader_transfers(&mut cluster); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Add a brief description of what this test case is for.
|
Rest LGTM |
AndreMouche
reviewed
Mar 17, 2017
| for read in self.reads.drain(self.ready_cnt..) { | ||
| for (req, cb) in read.cmds { | ||
| for mut read in self.reads.drain(self.ready_cnt..) { | ||
| for (req, cb) in read.cmds.drain(..) { |
There was a problem hiding this comment.
Is it just a refactoring behavior and have nothing to do with this PR?
There was a problem hiding this comment.
When drop is implemented, it can be moved partially.
| self.pending_reads.clear_uncommitted(&self.tag, term); | ||
| } | ||
| if ready.ss.is_some() { | ||
| let term = self.term(); |
There was a problem hiding this comment.
Why not clear for leader before?
There was a problem hiding this comment.
When the peer is not leader before, there will be no uncommitted in pending reads. Remove the check just make code more simple.
| return true; | ||
| } | ||
| return false; | ||
| return match self.block { |
There was a problem hiding this comment.
Can we add some annotations in this file, it's hard for me to understand?
There was a problem hiding this comment.
Sure, but not related to this pr.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback of read index isn't cleared when the peer is destroyed, which will lead to dead lock.
@siddontang @zhangjinpeng1987 @hhkbp2 PTAL