move region peer_cache to the peer cache itself #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any benchmark? |
|
LGTM |
|
I suggest moving peer_cache to another PR. |
|
OK, I will submit a new PR. |
lishuai87
changed the title
|
please merge PR #1861 first. "replace hashmap raft.prs with flatmap" |
|
Please rebase master. |
lishuai87
force-pushed
the
javaforfun/replace-hashmap-peer-cache
branch
from
7c2e543 to
a21be4d
Compare
|
PTAL @BusyJay |
BusyJay
reviewed
May 25, 2017
| @@ -192,14 +192,14 @@ pub struct PeerStat { | |||
| pub struct Peer { | |||
| engine: Arc<DB>, | |||
| cfg: Rc<Config>, | |||
| peer_cache: Rc<RefCell<HashMap<u64, metapb::Peer>>>, | |||
| peer_cache: RefCell<FlatMap<u64, metapb::Peer>>, | |||
There was a problem hiding this comment.
If it's not going to be shared, then RefCell is unnecessary.
There was a problem hiding this comment.
use RefCell for interior mutability, as get_peer_from_cache may insert new elem. e.g. store.validate_region
There was a problem hiding this comment.
I think it can be borrowed mutably.
There was a problem hiding this comment.
can we remove RefCell, @BusyJay ?
There was a problem hiding this comment.
@javaforfun please update it later.
|
LGTM |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
…ikv#1859) * add low priority scheduler Signed-off-by: Ping Yu <yuping@pingcap.cn> * make low priority pool optional Signed-off-by: Ping Yu <yuping@pingcap.cn> --------- Signed-off-by: Ping Yu <yuping@pingcap.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1843.