add region approximate size #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -1435,6 +1435,10 @@ impl Peer { | |||
| None | |||
| } | |||
|
|
|||
| pub fn approximate_size(&self) -> Result<u64> { | |||
There was a problem hiding this comment.
Don't add the calculation into raftstore thread, it might block raftstore thread.
There was a problem hiding this comment.
I think it is ok now, we will do it in another thread later
There was a problem hiding this comment.
I think it is ok now, we will do it in another thread later
There was a problem hiding this comment.
Do you mean I should put it in the worker instead of heartbeat_pd?
|
LGTM |
huachaohuang
force-pushed
the
huachao/approximate-size
branch
from
e383ec9 to
2b40e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get approximate region size from user properties.