coprocessor, dag: support decode Time from tipb.Expr #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Aug 24, 2017
src/coprocessor/dag/expr/mod.rs
Outdated
| @@ -379,6 +380,15 @@ impl Expression { | |||
| .map(Datum::F64) | |||
| .map(|e| Expression::new_const(e, tp)) | |||
| .map_err(Error::from), | |||
| ExprType::MysqlTime => expr.get_val() | |||
| .decode_u64() | |||
| .and_then(|ts| { | |||
There was a problem hiding this comment.
ts is confusing considering this is not a timestamp actually.
src/coprocessor/dag/expr/mod.rs
Outdated
| .and_then(|ts| { | ||
| let fsp = expr.get_field_type().get_decimal() as i8; | ||
| let tp = expr.get_field_type().get_tp() as u8; | ||
| Time::from_packed_u64(ts, tp, fsp, &FixedOffset::east(0)) |
There was a problem hiding this comment.
Should use timezone from context.
BusyJay
reviewed
Aug 24, 2017
src/coprocessor/dag/expr/mod.rs
Outdated
| let tz = if tp == types::TIMESTAMP { | ||
| ctx.tz | ||
| } else { | ||
| FixedOffset::east(0) |
There was a problem hiding this comment.
According to TiDB, all timestamp should be adjust to timezone UTC.
There was a problem hiding this comment.
I don't think it's correct. All time should be converted to the tz specified in context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.