Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: adjust label checks #2372

Merged
merged 2 commits into from
Oct 13, 2017
Merged

config: adjust label checks #2372

merged 2 commits into from
Oct 13, 2017

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Oct 11, 2017

Labels are case-insensitive, so accept upper case too.

@siddontang
Copy link
Contributor

LGTM

@huachaohuang
Copy link
Contributor

I think we should wait for PD to finish the case-insensitive conversion.

@siddontang
Copy link
Contributor

PTAL @huachaohuang @disksing

@overvenus
Copy link
Member

CC tikv/pd#794

@siddontang
Copy link
Contributor

Ping @disksing

disksing
disksing approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang siddontang merged commit c147f94 into master Oct 13, 2017
@siddontang siddontang deleted the busyjay/adjust-labels-check branch October 13, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@siddontang siddontang Awaiting requested review from siddontang

@overvenus overvenus Awaiting requested review from overvenus

@huachaohuang huachaohuang Awaiting requested review from huachaohuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BusyJay @siddontang @huachaohuang @overvenus @disksing