coprocessor: support unique index scan #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
AndreMouche
reviewed
Nov 29, 2017
| let r1 = get_idx_range(TABLE_ID, INDEX_ID, 0, 1); // point get | ||
| let r2 = get_idx_range(TABLE_ID, INDEX_ID, 1, 4); // range seek | ||
| let r3 = get_idx_range(TABLE_ID, INDEX_ID, 4, 5); // point get | ||
| let r4 = get_idx_range(TABLE_ID, INDEX_ID, 5, KEY_NUMBER + 1 as i64); // range seek |
There was a problem hiding this comment.
It seems KEY_NUMBER is defined as usize
| let mut scanner = IndexScanExecutor::new(wrapper.scan, wrapper.ranges, store, true); | ||
|
|
||
| for tid in 0..KEY_NUMBER { | ||
| let handle = KEY_NUMBER - tid - 1; |
There was a problem hiding this comment.
The result should be order by handle ascending since desc in request is false.
|
@breeswish PTAL |
|
@coocood PTAL |
|
LGTM |
|
@AndreMouche Can we merge now? |
|
/run-integration-tests |
AndreMouche
approved these changes
Dec 8, 2017
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get interface when scanning unique index.
@AndreMouche PTAL