[cherry-pick] iterator lower bound and optimized ingesting sst #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
hicqu
reviewed
Dec 6, 2017
src/coprocessor/select/select.rs
Outdated
| @@ -152,7 +152,12 @@ impl<'a> SelectContext<'a> { | |||
| } else { | |||
| range.get_start().to_vec() | |||
| }; | |||
| let upper_bound = if !self.core.desc_scan && !range.get_end().is_empty() { | |||
| let lower_bound = if !range.get_start().is_empty() { | |||
There was a problem hiding this comment.
Could we set both lower bound and upper bound like we do in function init_with_range?
There was a problem hiding this comment.
Is is possible the start or end is empty?
hicqu
approved these changes
Dec 6, 2017
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.