store: change box err to stale epoch error #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Dec 19, 2017
| peer.tag, | ||
| region.get_region_epoch(), | ||
| epoch | ||
| return Err(Error::StaleEpoch( |
There was a problem hiding this comment.
why can return StaleEpoch fix the problem?
There was a problem hiding this comment.
The line 768 panics if the respone has a box error, however it will retry, if the error is the stale epoch.
|
LGTM PTAL @BusyJay |
|
/run-unit-test |
|
Nice catch. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2593 and #2487
Tests will retry when it meets stale epoch error.