tikv-ctl: dynamically modify rocksdb cache size #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMouche
reviewed
Apr 8, 2018
src/server/debug.rs
Outdated
| opt.push((config_name, config_value)); | ||
| box_try!(rocksdb.set_options_cf(handle, &opt)); | ||
| // currently we can't modify block_cache_capacity via set_options_cf | ||
| if config_name == "block_cache_capacity" { |
There was a problem hiding this comment.
Could we modify the function set_options_cf and let it support modify block_cache_capacity ?
…b.com/UncP/tikv into dynamically-modify-rocksdb-cache-size
src/server/debug.rs
Outdated
| opt.push((config_name, config_value)); | ||
| box_try!(rocksdb.set_options_cf(handle, &opt)); | ||
| // currently we can't modify block_cache_capacity via set_options_cf | ||
| if config_name == "block_cache_capacity" { |
There was a problem hiding this comment.
Should keep consistent with cfg.
src/server/debug.rs
Outdated
| // currently we can't modify block_cache_capacity via set_options_cf | ||
| if config_name == "block_cache_capacity" { | ||
| let opt = rocksdb.get_options_cf(handle); | ||
| let capacity = config_value.parse::<u64>(); |
There was a problem hiding this comment.
Can we support MB and GB here?
There was a problem hiding this comment.
Sure, but this can only be used on cache size here, other cfgs is passed to rocksdb.
|
@huachaohuang PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.