raftstore/apply: Temporarily skip delete all in range #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyonKeminta
changed the title
|
@zhangjinpeng1987 PTAL |
|
If use_delete_range is true, don't skip the cleanup process. |
|
LGTM |
MyonKeminta
changed the title
BusyJay
reviewed
May 14, 2018
tests/raftstore/cluster.rs
Outdated
| // Set this flag to pass tests. (Issue #3034) | ||
| // TODO: Remove it after apply pool is implemented. | ||
| // TODO: In the future, maybe it's better to test both true and false | ||
| cfg.raft_store.use_delete_range = true; |
There was a problem hiding this comment.
If this is false, what cases will fail?
There was a problem hiding this comment.
raftstore_cases::test_single::test_node_delete_range
raftstore_cases::test_single::test_server_delete_range
There was a problem hiding this comment.
Can you adapt those cases instead? We should test the default settings. By the way, only the server case is necessary, the node case is duplicated.
tests/raftstore/cluster.rs
Outdated
| Duration::from_secs(5), | ||
| ); | ||
| fn get_impl(&mut self, cf: &str, key: &[u8], read_quorum: bool) -> Option<Vec<u8>> { | ||
| let req = match cf { |
There was a problem hiding this comment.
We can reuse new_get_cf_cmd when cf is default.
|
LGTM |
tests/raftstore/cluster.rs
Outdated
| @@ -109,6 +109,7 @@ impl<T: Simulator> Cluster<T> { | |||
| sim: Arc<RwLock<T>>, | |||
| pd_client: Arc<TestPdClient>, | |||
| ) -> Cluster<T> { | |||
| // TODO: In the future, maybe it's better to test both true and false | |||
src/server/service/kv.rs
Outdated
| @@ -585,6 +585,7 @@ impl<T: RaftStoreRouter + 'static> tikvpb_grpc::Tikv for Service<T> { | |||
| ctx.spawn(future); | |||
| } | |||
|
|
|||
| // WARNING: Currently this API may last some dirty keys in TiKV. Be careful using this API. | |||
|
/run-integration-tests |
|
/run-integration-ddl-test tidb-test=pr/526 |
1 similar comment
|
/run-integration-ddl-test tidb-test=pr/526 |
|
/run-integration-ddl-test |
|
/run-integration-ddl-test tidb-test=pr/526 |
1 similar comment
|
/run-integration-ddl-test tidb-test=pr/526 |
|
/run-all-tests |
Merged
MyonKeminta
added a commit
to MyonKeminta/tikv
that referenced
this pull request
May 15, 2018
overvenus
pushed a commit
to overvenus/tikv
that referenced
this pull request
May 15, 2018
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to #3034
This PR skips the second step of delete range (
delete_all_in_range) temporarily.However in order to make this change, some tests about delete range have to be bypassed, which is somewhat dangerous. Please make sure we do really need this before merging this.
Related pull request in TiDB: pingcap/tidb#6512