coprocessor/codec: remove read trait from datum and table in decode f… #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breezewish
reviewed
May 11, 2018
src/coprocessor/codec/datum.rs
Outdated
| pub fn decode_datum(data: &mut BytesSlice) -> Result<Datum> { | ||
| if !data.is_empty() { | ||
| let flag = data[0]; | ||
| *data = unsafe { data.get_unchecked(1..) }; |
There was a problem hiding this comment.
What is this used for? Or, do we have ways without unsafe?
There was a problem hiding this comment.
Use &data[1..] is the same here. Because data.is_empty() has provide the hint to compiler.
|
LGTM |
|
/run-integration-tests |
hicqu
approved these changes
May 14, 2018
|
LGTM. |
sticnarf
pushed a commit
to sticnarf/tikv
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, this PR remove the read trait from datum and table in decode function.
@BusyJay @breeswish @hicqu PTAL