Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion needs improvement #1456

Closed
dveeden opened this issue Jun 25, 2021 · 2 comments
Closed

Shell completion needs improvement #1456

dveeden opened this issue Jun 25, 2021 · 2 comments
Labels
type/feature-request Categorizes issue as related to a new feature.

Comments

@dveeden
Copy link
Contributor

dveeden commented Jun 25, 2021

Feature Request

There is tiup completion but it has multiple issues:

I think tiup components are a bit similar to git commands. And for git there is this: https://github.com/git/git/blob/master/contrib/completion/git-completion.bash to allow additional tools like git-extras

Maybe tiup should have a list of known/registered components and then run the component like tiup <component> completion which then can emit the right output similar to what git uses.

@dveeden dveeden added the type/feature-request Categorizes issue as related to a new feature. label Jun 25, 2021
@nexustar
Copy link
Collaborator

thanks for your contribution. cobra has completion support since 1.2.0 . So we will use cobra build-in function and trick it at #1688

@nexustar
Copy link
Collaborator

nexustar commented Jun 8, 2022

tiup has usable shell completion since v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants