Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version info will be missing if change offline package #594

Closed
lucklove opened this issue Jul 9, 2020 · 3 comments
Closed

Version info will be missing if change offline package #594

lucklove opened this issue Jul 9, 2020 · 3 comments
Labels
status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Milestone
v1.1.0

Comments

@lucklove
Copy link
Member

lucklove commented Jul 9, 2020 •
edited
Loading

After change from v4.0.1 -> v4.0.2:

# export TIUP_MIRRORS=/data/tidb/tidb-ansible-dir/tiup_binary/tidb-community-server-v4.0.2-linux-amd64
# tiup cluster
WARNING: both mirror config(/data/tidb/tidb-ansible-dir/tiup_binary/tidb-community-server-v4.0.1-linux-amd64)
and TIUP_MIRRORS(/data/tidb/tidb-ansible-dir/tiup_binary/tidb-community-server-v4.0.2-linux-amd64) have been set.
Setting mirror to TIUP_MIRRORS(/data/tidb/tidb-ansible-dir/tiup_binary/tidb-community-server-v4.0.2-linux-amd64)
Failed to start component `cluster`
Error: no version: v1.0.6
@lucklove lucklove added the type/bug Categorizes issue as related to a bug. label Jul 9, 2020
@lucklove
Copy link
Member Author

lucklove commented Jul 9, 2020

This is because we will run the installed last stable version if the user doesn't specific a version for a component(cluster). And we install v1.0.6, so we try to find v1.0.6 in offline package v4.0.2 where it doesn't exists.

@lucklove lucklove added the status/TODO Categorizes issue as we will do it. label Jul 9, 2020
@lucklove
Copy link
Member Author

lucklove commented Jul 9, 2020

TODO:

  • Clone the whole component manifest instead of only the target version
  • Yank all versions in the manifest except target version
  • Deal with the yanked versions in the list command and last stable function

@lucklove lucklove added this to the v1.1.0 milestone Jul 10, 2020
@AstroProfundis
Copy link
Contributor

Fixed in #602, #635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/TODO Categorizes issue as we will do it. type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@AstroProfundis @lucklove