Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param value for --wait-timeout can not be negative number #813

Closed
seiya-annie opened this issue Sep 24, 2020 · 0 comments · Fixed by #818
Closed

Param value for --wait-timeout can not be negative number #813

seiya-annie opened this issue Sep 24, 2020 · 0 comments · Fixed by #818
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.

Comments

@seiya-annie
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    input tiup dm display test1 --wait-timeout -1

  2. What did you expect to see?

return error for param invalid

  1. What did you see instead?

[root@localhost ~]# tiup dm display test1 --wait-timeout -1
Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm display test1 --wait-timeout -1
dm Cluster: test1
dm Version: v2.0.0-rc
ID Role Host Ports OS/Arch Status Data Dir Deploy Dir


172.16.5.197:9093 alertmanager 172.16.5.197 9093/9094 linux/x86_64 Up /home/tidb/dm/data/alertmanager-9093 /home/tidb/dm/deploy/alertmanager-9093
172.16.5.197:8261 dm-master 172.16.5.197 8261/8291 linux/x86_64 Healthy|L /home/tidb/dm/data/dm-master-8261 /home/tidb/dm/deploy/dm-master-8261
172.16.5.197:8262 dm-worker 172.16.5.197 8262 linux/x86_64 Free /home/tidb/dm/data/dm-worker-8262 /home/tidb/dm/deploy/dm-worker-8262
172.16.5.197:3000 grafana 172.16.5.197 3000 linux/x86_64 Up - /home/tidb/dm/deploy/grafana-3000
172.16.5.197:9090 prometheus 172.16.5.197 9090 linux/x86_64 Up /home/tidb/dm/data/prometheus-9090 /home/tidb/dm/deploy/prometheus-9090
[root@localhost ~]#

  1. What version of TiUP are you using (tiup --version)?
    [root@localhost ~]# tiup --version
    v1.0.9 tiup
    Go Version: go1.13
    Git Branch: master
    GitHash: 41fbacf
    [root@localhost ~]# tiup dm --version
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
    tiup version v1.1.2 tiup
    Go Version: go1.13
    Git Branch: release-1.1
    GitHash: 7cb85b9-dirty
    [root@localhost ~]#
@seiya-annie seiya-annie added the type/bug Categorizes issue as related to a bug. label Sep 24, 2020
@lucklove lucklove added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants