Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENV_LABELS_ENV in prometheus‘s alert rules file is not replace to tidb cluster name #990

Closed
Damon-Guo opened this issue Dec 14, 2020 · 2 comments · Fixed by #1238
Closed

ENV_LABELS_ENV in prometheus‘s alert rules file is not replace to tidb cluster name #990

Damon-Guo opened this issue Dec 14, 2020 · 2 comments · Fixed by #1238
Labels
category/monitoring Categorizes issue or PR related to monitoring components. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.
Milestone
v1.4.0

Comments

@Damon-Guo
Copy link

Damon-Guo commented Dec 14, 2020 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?

When Tiup deploys alertmanager, the defined name is not written into the alarm information in alertmanager, so it is not known the alarm information comes from which cluster.

  1. What did you expect to see?
    ENV_LABELS_ENV in prometheus‘s alert rules file is replaced by tidb cluster name

  2. What did you see instead?
    ENV_LABELS_ENV in prometheus‘s alert rules file is not replace to tidb cluster name

  3. What version of TiUP are you using (tiup --version)?
    1.2.5
@Damon-Guo Damon-Guo added the type/bug Categorizes issue as related to a bug. label Dec 14, 2020
@AstroProfundis AstroProfundis added the category/monitoring Categorizes issue or PR related to monitoring components. label Dec 15, 2020
@King-Dylan
Copy link
Contributor

When Tiup deploys alertmanager, the defined name is not written into the alarm information in alertmanager, so it is not known which cluster the alarm information comes from.

@King-Dylan King-Dylan added this to the v1.4.0 milestone Jan 25, 2021
@buggithubs buggithubs reopened this Mar 23, 2021
@lucklove lucklove modified the milestones: v1.4.0, Next Mar 23, 2021
@buggithubs
Copy link

image

When multiple clusters have the same receiver, the source cannot be distinguished；Please configure the information correctly “ ENV_LABELS_ENV”

@lucklove lucklove added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 23, 2021
@Damon-Guo Damon-Guo changed the title ENV_LABELS_ENV in prometheus‘s alter rules file is not replace to tidb cluster name ENV_LABELS_ENV in prometheus‘s alert rules file is not replace to tidb cluster name Mar 23, 2021
@9547 9547 mentioned this issue Mar 23, 2021
Merged
@AstroProfundis AstroProfundis modified the milestones: Next, v1.4.0 Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/monitoring Categorizes issue or PR related to monitoring components. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/bug Categorizes issue as related to a bug.
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

cluster,dm: replace ENV_LABELS_ENV in prometheus rules jsvisa/tiup
5 participants
@AstroProfundis @lucklove @buggithubs @Damon-Guo @King-Dylan