Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.2 #9

Open
ghost opened this issue Jan 6, 2016 · 6 comments
Open

Laravel 5.2 #9

ghost opened this issue Jan 6, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Jan 6, 2016

Laravel 5.2 Support is missing.

@gravitano Can u implement this ?

@adrianthedev
Copy link

+1

Thank you!

@ghost
Copy link
Author

ghost commented Jan 19, 2016

@gravitano Status ???

@gravitano
Copy link
Member

@heikobihlmaier Do you get any errors? This package is not require any illuminate package.

@ghost
Copy link
Author

ghost commented Jan 21, 2016

With version tag 2.2 I get an error, because thunder/shortcode is not available in any stable version. I need to add

"minimum-stability": "dev",
"prefer-stable":     true

for install.

Without that the installation of your package is not possible.
Addional is your documenation of this package not useful, because there is nothing correct.

I used it so: is this correct ?

\Shortcode::register('icon', function(ShortcodeInterface $shortcode) {
            echo $shortcode->getName().': '.$shortcode->getContent() . ':' . $shortcode->getParameter('lib');
        });

Greetings from Germany.

@gravitano
Copy link
Member

Try install the latest commit from branch 2.2. I've been tried in my Local machine and everything is fine.

@thunderer
Copy link
Contributor

@heikobihlmaier Yes, thunderer/shortcode was in dev-master here, but it is changed to 0.5.* in branch 2.2. I suggest changing it to ^0.5 so that it'll automatically cover new releases in 0.*. @gravitano Could you please release 2.2.0 with said changes? If there are any questions, let me know how could I help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants