Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.formatters.level does not inline attributes into message anymore #1966

Closed
timtrense-leadec opened this issue May 6, 2024 · 3 comments

Comments

@timtrense-leadec
Copy link

after trying out the sample code of PR#1898 with v9.0.0 I sadly must report that the level formatter for browser does not inline the contained attributes anymore, but blindly puts a level object in the resulting log entry.

Expected:

{
  time: 1707198967745,
  label: 'info',
  level: 30,
  msg: 'I am logging a message from the middleware'
}

Actual:

{
  time: 1707198967745,
  level: {label: 'info', level: 30},
  msg: 'I am logging a message from the middleware'
}
@timtrense-leadec
Copy link
Author

This seems to be a degradation after v.8.19.0 in 7f33a0e

In deleted line 339 there used to be an Object.assign, whereas now in added line 338 is a simple assignment of o.level = levelFormatter(...).

@emmyakin
Copy link
Contributor

This changes causing this bug has been reverted in #1971, and thus fixed

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants